bcgov / bcgov/alcs

Fix Linting in ALCS Repo for Full SonarCloud Analysis

Open
#2,641 0 comments 0 reactions 0 assignees View on GitHub
Task
Dominant language
TypeScript
Stars
10
Forks
0
Avg merge
20h 8m
Merged PRs (30d)
30

Description

**Describe the task**
Fix ESLint errors and warnings across backend, ALCS frontend, and Portal frontend to meet code quality standards and unblock SonarCloud analysis.

**Purpose**
- Remove linting errors so SonarCloud can complete a full analysis to bcgov standards
- Improve code quality and maintainability
- Enforce consistent code style
- Reduce technical debt

**Acceptance Criteria**
- [ ] All projects pass npm run lint with zero errors
- [ ] Warnings are either fixed or analyzed, and possibly documented as acceptable tech debt for now

**Additional context**
- Current status: Coverage path issues are fixed; linting errors remain
- Backend errors: mostly unused variables/imports in service and controller files
- Frontend errors: Angular ESLint rules (output bindings, component selectors, empty lifecycle methods)
- Frontend warnings: accessibility (click events need keyboard events) and lifecycle interface implementations
These are pre-existing issues, not introduced by recent changes
- Consider using ESLint --fix for auto-fixable issues
- Reference: SonarCloud workflow at .github/workflows/sonarcloud.yml

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reviewing .github/workflows/sonarcloud.yml and running npm run lint for each project to identify the backend and frontend failures. Use ESLint --fix for auto-fixable issues, then address the remaining errors and review the accessibility and lifecycle warnings. Done means all projects pass with zero errors and remaining warnings are fixed or documented.

Written by the indexing model from the issue text.

Assessment

Tech stack
angular, eslint, typescript
Domain
backend, ci-cd, frontend, tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.