bcgov / bcgov/alcs

Linked request field on NOI subsequent decision bypassing release validation

Open
#2,617 1 comment 0 reactions 0 assignees View on GitHub
Bug
Dominant language
TypeScript
Stars
10
Forks
0
Avg merge
20h 8m
Merged PRs (30d)
30

Description

**Describe the Bug**
Users releasing a 2nd/3rd/4th etc NOI decision are able to successfully release the decision without a selection in the mandatory Linked Request field

**Expected Behaviour**
A selection in the Linked Request field is mandatory for any decision after the first decision.

**Actual Behaviour**
If the user never touches the Linked Request field while the fill out the Decision Draft, then they can release the decision without a selection in the field.

** Steps To Reproduce**
Steps to reproduce the behaviour:
1. Populate and release a first NOI decision
2. Create a second decision draft
3. Fill out all the mandatory fields EXCEPT Linked Request (and don't touch the field)
4. Hit Release Decision button
5. User can confirm the popup and release is successful

See d2 on https://alcs-dev.apps.silver.devops.gov.bc.ca/notice-of-intent/100396/decision

Find them in Metabase: https://alcs-metabase-prod.apps.silver.devops.gov.bc.ca/question/1023-noi-modification-decisions-missing-the-request-link

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reproducing the second-decision release flow at the linked NOI decision page, leaving Linked Request untouched. Trace the validation behind Release Decision and compare it with a first decision; done means every subsequent NOI decision blocks release until Linked Request has a selection.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
65/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.