bcgov / bcgov/alcs

Linked Request / Reconsideration Request relationship is bugging

Open
#2,340 1 comment 0 reactions 1 assignee Claimed by @ancharb View on GitHub
Bug
Dominant language
TypeScript
Stars
10
Forks
0
Avg merge
20h 8m
Merged PRs (30d)
30

Description

**Describe the Bug**
Linked Request field on Application decisions is showing more than just 'Proceed to Reconsider' requests, and it's not numbering the requests properly, which is causing issues with deleting along the chain. It's also showing up disabled on the First decision, when it shouldn't be there at all.

**Expected Behaviour**
1. Linked Request field shouldn't show requests that are Pending or Refused to Reconsider
2. Reconsideration Requests should be numbered correctly in the Linked Request field
3. I should be able to delete the end of the chain of reconsideration requests and decisions
4. New Reconsideration Requests are Outcome = Pending by default
5. First decisions do not have the Linked Request field

**Actual Behaviour**
1. In the Linked Request field, I can select a Reconsideration Request that has Outcome = Pending but when I try to save the decision, I get a red error toast **-> cant reproduce anymore**
2. Recon and modification indexing is jumping around -> created separate ticket
3. Linked request field shows 'Reconsideration Request no.2 - no.1 /2024', but Request No.1 is associated with no.1/2024, not Request no.2. And if I keep adding Reconsideration Requests, the index in the Linked Request field is always the highest index, and I can't select any other reconsideration requests. -> hoping the bug fix above fixes this
4. I can delete reconsideration requests that are mid-chain, but not the one with the highest index (because it seems to be associated with a decision in bug #2) -> hoping that the bug fix above fixes this
5. New Reconsideration Requests are getting Outcome = Proceed to Reconsider by default **-> cant reproduce anymore**
6. First decisions have a disabled Linked Request field -> created separate ticket

** Steps To Reproduce**
Go to https://alcs-dev.apps.silver.devops.gov.bc.ca/application/100007/decision, you can see how all these bugs are showing up. I can also walk you through it because it's complicated. Also I can't put hashtags in this ticket because it inserts GH ticket links so I used 'no.' instead.

Haven't tested Modification flow yet

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.