bcgov / bcgov/alcs

Change authentication to use subject value

Open
#2,339 0 comments 0 reactions 0 assignees View on GitHub
Task
Dominant language
TypeScript
Stars
10
Forks
0
Avg merge
20h 8m
Merged PRs (30d)
30

Description

It is low priority, but considered better practice to use the token's subject value ("sub" attribute) for identifying users when authenticating rather than "bceif_user_guid" and "idir_user_guid".

**Purpose**
To improve security.

**Acceptance Criteria**
- [ ] Both portal and ALCS authentication uses "sub" value for authentication rather than "bceid_user_guid" and "idir_user_guid"

**Additional context**
- This issue was a result of #2330
- https://openid.net/specs/openid-connect-core-1_0.html#SubjectIDTypes

Contributor guide

No contributing guide indexed for this repository

Research direction

No files or tests are named; start by locating the portal and ALCS authentication entry points and review issue #2330 for context. Check the OpenID Connect SubjectIDTypes specification, then verify that both authentication paths use the token's "sub" value and no longer use the two GUID attributes.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
authentication, security
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.