BUG: Expiry Date of registration using incorrect calculation

**Current Behaviour**
When a STR becomes registered, the expiry date looks like it is being calculated as 12:00:01 am of the day it was created, plus a year:
Examples:

**Desired Behaviour**
If a registration number is assigned (draft creation date) on MON-DD-YYYY at any time, it should expire on (MON-DD -1 day), YYYY + 1 year at 11:59:59 pm. For example, If the Registration number is assigned April 21, 2026, it expires April 20, 2027 11:59:59pm (not April 21, 2027 12:01am)

**Reason for Change**
Expiry dates should be calculated consistently and expire consistently across STRR and match the legislation.

## Acceptance Criteria
Find a registered STR that was auto approved on a certain date.
Make sure the expiry date that is shown on the registration matches the date of the auto approval + 1 year - 1 day.
Make sure that the expiry process (registration becomes expired) occurs at 11:59:59 of the date of the expiry date.

Find a registered STR that was examined and approved on a certain date
Make sure the expiry date that is shown on the registration matches the date of the auto approval + 1 year - 1 day.
Make sure that the expiry process (registration becomes expired) occurs at 11:59:59 of the date of the expiry date.

Trace the registration approval paths for auto-approved and examined STRs, then follow the expiry process described in the acceptance criteria. Verify that the displayed expiry date is approval date plus one year minus one day and that the registration becomes expired at 11:59:59 on that date.

Written by the indexing model from the issue text.