bcgov / bcgov/STRR

BUG: NOC expiry dates working differently on applications versus registrations.

Open
#1,559 0 comments 0 reactions 0 assignees View on GitHub
bug Priority3 STR
Dominant language
Python
Stars
2
Forks
22
Avg merge
2d 35m
Merged PRs (30d)
11

Description

**Current Behaviour**
When an examiner sends a NOC on an application, the NOT expiry date is calculated shows a different date than when a NOC is sent on a registration. Both NOCS were sent within minutes of each other today, April 21st.
image.png
image.png

**Desired Behaviour**
the NOC expiry date should be calculated the same for all rental types across applications and registrations. The NOC expiry date in both instances should be 11:59:59 pm on the eighth day counted using the interpretation act.
Example: Example: NOC sent April 21, 2026 NOC expires April 29, 2026 11:59:59pm (the system was telling hosts that it expires April 30, 2026 12:01 am)

**Reason for Change**
NOC expiry dates should be calculated consistently and occur consistently across STRR and match the legislation.

## Acceptance Criteria
Generate a NOC for an application.
Generate a NOC for a registration right after the previous step.
the NOC expiry date for both should be 11:59:59 pm on the eighth day from today's date.
Make sure that the NOC expires at 11:59:59 pm on the eighth day from today's date.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by generating a NOC for an application and then for a registration, as described in the acceptance criteria, and compare their expiry calculations. Trace the code paths that calculate each date and verify that both use the interpretation-act eighth-day rule and end at 11:59:59 pm; done means both instances show the same expiry date.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.