bcgov / bcgov/SIMS

Institution Creation Backend Validation

Open
#6,458 0 comments 0 reactions 1 assignee Claimed by @uhelm View on GitHub
Technical Debt
Dominant language
TypeScript
Stars
29
Forks
15
Avg merge
1d 13h
Merged PRs (30d)
40

Description

As part of the #6452 hotfix, it was identified that the backend validations for the institution creation are not fully aligned with the UI.

**Acceptance criteria**
- [ ] Review the UI validations and ensure the API DTOs are in sync with the UI.
- [ ] Review the different paths for:
- [ ] Institution create/updated by the ministry; and
- [ ] Institution create/updated by the institution; and
- [ ] Any other UI affected by a shared DTO (e.g., address validation).
- [ ] For DTOs that are potentially shared, for instance, address validation, ensure the dependent DTO-related UI is in sync with the validations.
- [ ] For instance, when applying a max length constraint to the shared [AddressDetailsAPIInDTO](https://github.com/bcgov/SIMS/blob/main/sources/packages/backend/apps/api/src/route-controllers/models/common.dto.ts#L39-L85), ensure student and location addresses are also taken into consideration.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.