bcgov / bcgov/SIMS

FT MSFAA - Handle non-SIMS record logs

Open
#4,919 0 comments 0 reactions 0 assignees View on GitHub
Business
Dominant language
TypeScript
Stars
29
Forks
15
PR merge metrics
No merged PRs in 30d

Description

- [ ] Update error message to be more similar to others when dealing with non-SIMS records

**Current Error message log**
```[2025-07-11 15:24:44]--ERROR: Error processing record line number 67 from file IN/TEDU.PBC.MSFA.REC.20250709.001. {
"stack": "Error: MSFAA number 0000504254 not found for offering intensity Full Time.\n at MSFAANumberService.updateReceivedRecord (webpack://api/libs/integrations/src/services/msfaa-number/msfaa-number.service.ts:142:13)\n at process.processTicksAndRejections (node:internal/process/task_queues:105:5)\n at async MSFAAResponseProcessingService.processReceivedRecord (webpack://api/libs/integrations/src/esdc-integration/msfaa-integration/msfaa-response.processing.service.ts:123:5)\n at async MSFAAResponseProcessingService.processFile (webpack://api/libs/integrations/src/esdc-integration/msfaa-integration/msfaa-response.processing.service.ts:74:9)\n at async MSFAAResponseProcessingService.processResponses (webpack://api/libs/integrations/src/esdc-integration/msfaa-integration/msfaa-response.processing.service.ts:39:7)\n at async FullTimeMSFAAProcessResponseIntegrationScheduler.process (webpack://api/apps/queue-consumers/src/processors/schedulers/esdc-integration/msfaa-integration/msfaa-full-time-process-response-integration.scheduler.ts:35:5)\n at async FullTimeMSFAAProcessResponseIntegrationScheduler.processQueue (webpack://api/apps/queue-consumers/src/processors/schedulers/base-queue.ts:42:22)",
"message": "MSFAA number 0000504254 not found for offering intensity Full Time."```

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at libs/integrations/src/services/msfaa-number/msfaa-number.service.ts around line 142, where the logged error is raised, and trace the call from MSFAAResponseProcessingService.processReceivedRecord. Compare the non-SIMS record failure with the other error messages in this service. Done means the error message for this case follows the requested wording more closely.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.