bcgov / bcgov/SIMS

Items that were removed from the top of the list shows updated section when there is no change in order

Open
#4,311 1 comment 0 reactions 2 assignees Claimed by @astridSABC View on GitHub
Business Enhancement Ministry Test Case
Dominant language
TypeScript
Stars
29
Forks
15
PR merge metrics
No merged PRs in 30d

Description

**Describe the Bug**
Updated is shown to the 2nd item that was added to the list when the first one was removed

**Expected Behaviour**
When an item is removed from the list no 'updated' edit should be added

**Actual Behaviour**
The "Updated" edit highlight is displayed for the item that was 2nd in the list

### ** Steps To Reproduce**
1. Student (single) has submitted a new application with 0 eligible dependants and is at assessment status (see below "Added Dependants")

Student first edit ever to this application
2. Click "edit" beside the application that is at assessment
3. Click "edit application"

Family information tab
4. Add 2 new students with the same date of birth (or different birth year) - birth might not be relevant
5. Submit the application

6. Login to the ministry portal to view the edited application and note the dependants

**Added dependants**
image.png

7. Login to the student account and remove a dependant from the top of the Add dependants list.
8. Submit the application

9. Login to the ministry portal to view the most recent application and note the dependants (see below Removed 1st defendant)

**Removed first dependant**
image.png

Additional context:
Seems to relate to the changing of the order or when a option is removed higher in the stack the shift to the stack order flags as an actual change. It seems that it alters the comparison of the list items and leads to a discrepancy.

Ref: TQ TC 4252
App: 2024000913

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.