bcgov / bcgov/SIMS

Create / Update e2e tests for the Ministry Notifications

Open
#3,184 1 comment 0 reactions 1 assignee Claimed by @ninosamson View on GitHub
Dev & Architecture E2E/Unit tests Ministry Task
Dominant language
TypeScript
Stars
29
Forks
15
Avg merge
1d 14h
Merged PRs (30d)
38

Description

**User Story**

Create e2e tests for various notifications sent to the ministry:

**Acceptance Criteria:**

**Technical ACs:**

- [ ] Create e2e tests for the following controller endpoints:

e2e test for institution adds pending offering notification:
--- `createOffering` in `education-program-offering.institutions.controller.ts`
--- `bulkInsert` in `education-program-offering.institutions.controller.ts`
--- `updateProgramOffering` in `education-program-offering.institutions.controller.ts`

e2e test for institution adds pending program notification:
--- `createEducationProgram` in `education-program.institutions.controller.ts`
--- `updateEducationProgram` in `education-program.institutions.controller.ts` (no pre-existing tests here)

e2e test for institution requests designation notification:
--- `submitDesignationAgreement` in `designation-agreement.institutions.controller.ts`

e2e test for application offering change request approved by student:
--- `updateApplicationOfferingChangeRequest` in `application-offering-change-request.students.controller.ts`

e2e test for student requests basic BCeID Account:
--- `create` in `student-account-application.students.controller.ts` (no pre-existing tests here)

e2e test for student submits change request after COE:
--- `submitStudentAppeal` in `student-appeal.students.controller.ts`

e2e test for student edited application too many times:
--- `submitApplication` in `application.students.controller.ts`

e2e test for student file upload:
--- `saveStudentUploadedFiles` in `student.students.controller.ts`

- [ ] Update e2e tests for the following controller endpoints:

e2e test for when creating application exception request:
--- `verifyApplicationExceptions` in `application.controller.ts`

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.