bcgov / bcgov/SIMS

Fix type errors for the Modal Dialogs

Open
#2,224 0 comments 0 reactions 0 assignees View on GitHub
Bug
Dominant language
TypeScript
Stars
29
Forks
15
PR merge metrics
No merged PRs in 30d

Description

**Describe the Bug**
Fix type error for all the modals

**Expected Behavior**
There should be no type error for the modal dialogs.

**Actual Behavior**
Modal Dialog components (like `ApproveApplicationOfferingChangeRequestModal`, `DeclineApplicationOfferingChangeRequestModal`, `ApproveProgramModal` and `DeclineProgramModal`) etc show type errors as below:

[Private Zenhub Image](https://api.zenhub.com/attachedFiles/eyJfcmFpbHMiOnsibWVzc2FnZSI6IkJBaHBBaWxPIiwiZXhwIjpudWxsLCJwdXIiOiJibG9iX2lkIn19--e7491eddf0f159c5b4eb1d3e715cfe268b6ebc14/image.png)

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the modal dialog components named in the issue, including ApproveApplicationOfferingChangeRequestModal, DeclineApplicationOfferingChangeRequestModal, ApproveProgramModal, and DeclineProgramModal. Run the project's type checker to reproduce the reported errors, then inspect the affected modal types. Done means the modal dialogs report no TypeScript errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.