bazelbuild / bazelbuild/rules_rust

Encapsulate rust toolchain details behind a depset with all inputs

Open
#843 1 comment 0 reactions 1 assignee Claimed by @hlopko View on GitHub
maintenance needs-triage Technical debt
Dominant language
Starlark
Stars
843
Forks
651
Avg merge
2d 18h
Merged PRs (30d)
15

Description

Right now, rust_toolchain has many simple fields that return rustc binary, rustc_lib files, C++ toolchain files, rust stdlib files, or with https://github.com/bazelbuild/rules_rust/pull/836 also target json file.

AFAIK there is not a good reason why we need these fine grained artifacts. It will be more convenient to use and more backward-compatibility-friendly to expose one "all inputs relevant to compilations" depset that contains all users need. What's even better is that Bazel can save a bit of memory by reusing this single depset instead of creating slightly duplicated ones.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.