bazelbuild / bazelbuild/rules_rust

Annotations enabling a feature can't affect dependency resolution

Open
#3,626 1 comment 3 reactions 0 assignees View on GitHub
Dominant language
Starlark
Stars
843
Forks
651
Avg merge
2d 18h
Merged PRs (30d)
15

Description

AFAICT if you do something like:

```
annotations = {
"rustls": [
crate.annotation(
crate_features = ["fips"],
),
],
```

This doesn't impact the dependencies resolved. Splicing appears to completely ignore annotations, and we only apply them at generation time, which is too late to impact resolution.

We should grab feature annotations at splice time so they impact dependency resolution.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.