bazelbuild / bazelbuild/rules_rust

Remove conditional attribute switch from rules_rust

Open
#2,425 0 comments 0 reactions 1 assignee Claimed by @buildbreaker2021 View on GitHub
needs-triage
Dominant language
Starlark
Stars
843
Forks
651
Avg merge
2d 18h
Merged PRs (30d)
15

Description

Currently Bazel is using native `CcToolchainInfo` - meaning Java implementation of the provider.
There is an ongoing effort to rewrite provider in Starlark. Once that happens and Bazel knows of Starlark version of the provider remove conditional switch so that it always points to Starlark attribute. So instead of:

```
if hasattr(cc_toolchain, "_linker_files"):
linker_depset = cc_toolchain._linker_files
else:
linker_depset = cc_toolchain.linker_files()
```

We would have:
```
linker_depset = cc_toolchain._linker_files
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.