bazelbuild / bazelbuild/rules_pkg

Provide an upgrade path to V0.10 while preserving existing directory layouts

Open
#813 7 comments 3 reactions 0 assignees View on GitHub
P2
Dominant language
Starlark
Stars
253
Forks
221
Avg merge
10h 33m
Merged PRs (30d)
1

Description

The behavior of `pkg_tar`s `include_runfiles` attribute seems to have changed quite dramatically in the v0.10 release.

When combined with the `strip_prefix = "/"` attribute, the directory layout of the runfiles tree before it was just nested at the root of the tarball, i.e. a runfile at `$package_dir/path/to/file.yaml` would be found exactly in that place.

Since v0.10, the runfiles somehow end up at `$package_dir/$myservice.runfiles/$package_dir/path/to/file.yaml`.

This completely breaks our existing workflows and compatibility. The PR notes for this change (https://github.com/bazelbuild/rules_pkg/pull/754) in my opinion do not really capture the magnitude of this breaking change. Could you describe a way to preserve the old behavior? I think many users upgrading to v0.10 will run into this issue.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.