bazelbuild / bazelbuild/rules_pkg

PackageSymlinkInfo provider has confusing terminology

Open
#536 2 comments 0 reactions 0 assignees View on GitHub
p4
Dominant language
Starlark
Stars
253
Forks
221
Avg merge
10h 33m
Merged PRs (30d)
1

Description

#496 updated `pkg_mklink` and `PackageSymlinkInfo` to refer to `target` and `link_name` instead of `src` and `dest`, or similar.

It looks like `PackageSymlinkInfo` still says `destination` instead of `link_name`:

https://github.com/bazelbuild/rules_pkg/blob/cce90a09cef0acc4e5e224631caf73dff77bd382/pkg/providers.bzl#L63-L73

Fix this and all provider uses.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.