bazelbuild / bazelbuild/rules_pkg

RPM source_date_epoch test should check rpmbuild version, not system rpm

Open
#455 3 comments 0 reactions 0 assignees View on GitHub
P3 rpm
Dominant language
Starlark
Stars
253
Forks
221
Avg merge
10h 33m
Merged PRs (30d)
1

Description

We have a skip in this test, but we dumbly check the system "rpm" binary than the rpmbuild binary used to build the RPM in the first place. We have skipping logic here:

https://github.com/bazelbuild/rules_pkg/blob/9748dfa1a9a884d4107e5980f4bb3fa330f18b15/pkg/tests/rpm/source_date_epoch/rpm_contents_vs_manifest_test.py#L57-L64

But it could not be working for numerous reasons. Investigate further.

_Originally posted by @nacl in https://github.com/bazelbuild/rules_pkg/pull/443#discussion_r742274241_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.