bazelbuild / bazelbuild/rules_pkg

package mapping rule "attributes" should be more strongly defined

Open
#369 2 comments 0 reactions 0 assignees View on GitHub
P3
Dominant language
Starlark
Stars
253
Forks
221
Avg merge
10h 33m
Merged PRs (30d)
1

Description

The current `pkg_attributes` macro has undefined behavior: each argument defaults to None and as is left open to interpretation by the package builder. This can leave some things dependent on the environment, losing hermiticity. Most important ones are likely user and the group

Some non-mutually-exclusive options:

- Leave it as-is.
- Set defaults in `pkg_attributes`
- Allow for overriding default attributes in `pkg_filegroup`
- Codify the behavior in the packaging rules level

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.