bazelbuild / bazelbuild/rules_pkg

pkg_filegroup framework should support templating

Open
#312 0 comments 0 reactions 0 assignees View on GitHub
P3
Dominant language
Starlark
Stars
253
Forks
221
Avg merge
10h 33m
Merged PRs (30d)
1

Description

In https://github.com/bazelbuild/rules_pkg/pull/273#discussion_r565706282, @aiuto mentioned a shortcoming in the pkg_filegroup framework -- that it doesn't support dynamic naming of files and paths based on attributes defined in `PackageVariablesInfo` providers.

Supporting templating is relatively straightforward, but what isn't necessarily clear is where the templating should go.

In the same thread as above, I [suggested](https://github.com/bazelbuild/rules_pkg/pull/273#discussion_r568126332) that one such option would be to resolve them in the grouping layer (`pkg_filegroup`). However, that may not be the best place. Maybe somewhere in the packaging layer would be better?

Tasks:

- [ ] Determine where templating should be resolved
- [ ] Determine what attributes should be templated
- [ ] Implement and test templating actions

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.