bazelbuild / bazelbuild/rules_license

Expand list of attributes inspected when collecting license information

Open
#49 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Starlark
Stars
85
Forks
37
PR merge metrics
No merged PRs in 30d

Description

## Expected Behavior
`LicensesInfo` / `LicenseInfo` will be collected by reviewing all attributes of objects passed in to the `gather_licenses_info` aspect.

## Actual Behavior
The list of attributes that are inspected for `LicenseInfo` / `LicensesInfo` does not gather licenses for all third party libraries included in an android app binary.

## Steps to Reproduce the Problem

1. Use `gather_licenses_info` aspect to collect license information for your `deps`

Note: the same way as shown in [this docstring](https://github.com/bazelbuild/rules_license/blob/main/rules/gather_licenses_info.bzl#L78)

## Specifications
- We found including `exports` allows us to find significantly more licenses when building an android binary.

- Version: 0.0.3
- Platform: Android

Contributor guide

Open the contributing guide

Research direction

Start with rules/gather_licenses_info.bzl and the gather_licenses_info docstring linked in the issue. Review which attributes are inspected for LicenseInfo and LicensesInfo, include exports as specified, and verify that the aspect gathers licenses from more third-party libraries in an Android binary.

Written by the indexing model from the issue text.

Assessment

Tech stack
android
Domain
build-system
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.