bazelbuild / bazelbuild/rules_license

Update add_licenses.py to query for SPDX licenses on its own

Open
#23 0 comments 0 reactions 0 assignees View on GitHub
P3
Dominant language
Starlark
Stars
85
Forks
37
PR merge metrics
No merged PRs in 30d

Description

Currently, running `add_licenses.py` requires an extra step to be run before it is executed:
```
wget https://github.com/spdx/license-list-data/raw/master/json/licenses.json
```
Also, `add_licenses.py` expects the `licenses.json` file to be in the correct place when it is executed, and it will fail if it is not found.

Instead, the call to download `licenses.json` from Github should be incorporated into the `add_licenses.py` script to remove the need for an extra step and room for user error

See PR review comment: https://github.com/bazelbuild/rules_license/pull/17#discussion_r789012979

Contributor guide

Open the contributing guide

Research direction

Start by reading add_licenses.py and the documented wget command for licenses.json. Trace where the script currently expects that file, then verify that running add_licenses.py no longer requires a separate download or a manually placed licenses.json file.

Written by the indexing model from the issue text.

Assessment

Tech stack
github, python
Domain
tooling
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.