bazelbuild / bazelbuild/rules_closure

protobuf well known types generated incorrectly

Open
#492 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
159
Forks
111
PR merge metrics
No merged PRs in 30d

Description

protoc should generate extra helper methods for well known types, such as Timesamp.toDate.
However these don't get generated when you use the library option to protoc, and it appears that rules_closure always uses the library option.

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the well-known-type generation through protoc with the library option used by rules_closure, and compare it with generation without that option. Check whether the expected Timestamp.toDate helper appears; done means rules_closure produces the extra helper methods for well-known types.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.