bazelbuild / bazelbuild/rules_cc

Why do most toolchains in this repo miss no_legacy_features?

Open
#397 0 comments 0 reactions 0 assignees View on GitHub
P3
Dominant language
Starlark
Stars
247
Forks
196
PR merge metrics
No merged PRs in 30d

Description

According to the Bazel documentation at https://bazel.build/docs/cc-toolchain-config-reference:

> [...], and for production toolchains consider adding no_legacy_features to make the toolchain more standalone.

Why is no_legacy_features only used by the Windows toolchain? Especially with the "Starlarkification" of toolchains that is going on, wouldn't it make sense to set this and make the features/action_configs on the toolchains self contained?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.