bazelbuild / bazelbuild/rules_cc

Windows tool paths should have `.exe` suffix

Open
#393 3 comments 0 reactions 0 assignees View on GitHub
P3
Dominant language
Starlark
Stars
247
Forks
196
PR merge metrics
No merged PRs in 30d

Description

This is somewhat of a cross-post of https://github.com/bazel-contrib/rules_foreign_cc/issues/1391. On Windows, omitting the `.exe` extension can work in some scenarios (direct invocation from shell), but fail in others.

Most notably, CMake will issue the confusing error of being able to query the GCC version (it can call the binary), but then reporting that no compiler exists at the path given.

When resolving MSYS2/MinGW/MSVC toolchains on Windows, we should ensure that the full path is given.

I already had to introduce this in an unrelated PR: https://github.com/bazelbuild/rules_cc/pull/390/commits/e5be0933b5984533a19f4405220983e7d6db4057

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.