bazelbuild / bazelbuild/rules_apple

apple_dynamic_framework_import regressions

Open
#746 9 comments 7 reactions 0 assignees View on GitHub
P3
Dominant language
Starlark
Stars
593
Forks
334
Avg merge
16h 48m
Merged PRs (30d)
9

Description

4ec36b79fd35633581f5e1eb51c0bc7aac3f6031 regressed `apple_dynamic_framework_import` in a couple ways:
- ~Generated provisioning profiles no longer work, since they aren't listed as an input into `ImportedDynamicFrameworkProcessor`~ Fixed with #856
- ~`ImportedDynamicFrameworkProcessor` needs `execution_requirements = {"no-sandbox": "1"}` when there is a provisioning profile otherwise the sandbox blocks it~ Fixed with #862
- When using `ipa_processor` a framework that is stripped of its code signature is no longer re-signed (in particular for us, when we strip bitcode and Swift symbols from a framework)

Contributor guide

Open the contributing guide

Research direction

Start by tracing the apple_dynamic_framework_import path through ipa_processor and ImportedDynamicFrameworkProcessor, focusing on the code-signature handling after framework stripping. Done means a stripped framework is re-signed again, while the provisioning-profile regressions remain covered by fixes #856 and #862.

Written by the indexing model from the issue text.

Assessment

Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.