bazelbuild / bazelbuild/rules_android_ndk

Remove "ndk/"-prefixed include path compatibility workarounds

Open
#32 2 comments 0 reactions 0 assignees View on GitHub
P2
Dominant language
Starlark
Stars
43
Forks
32
PR merge metrics
No merged PRs in 30d

Description

With the way that the native version of `android_ndk_repository` structured / symlinked the NDK into bazel's external repository directory, the way to include things like cpu-features was

```
#include "ndk/sources/android/cpufeatures/cpu-features.h"
```

With the way the Starlark version of `android_ndk_repository` structures the NDK symlinks, the `ndk/` prefix is not needed:
```
#include "sources/android/cpufeatures/cpu-features.h"
```

However this presents a migration issue for projects that use the native version of the rule, so a workaround was introduced to allow including the headers with the `ndk/` prefix (by adding another symlink that results in the previous include path). We should migrate projects and remove this workaround.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.