bazelbuild / bazelbuild/rules_android

Don't stamp manifest for standard package structure

Open
#24 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
Java
Stars
203
Forks
95
PR merge metrics
No merged PRs in 30d

Description

Unless projects define a Google3 style projects structure projects are required to specify the `custom_package` attribute on `android_library`. This forces a `ManifestMerger` action on every library which is wasteful (our `custom_package` values are the same as the `package` we specify in every `AndroidManifest.xml`.

We should introduce a flag to allow projects to use the `package` attribute from `AndroidManifest.xml` if desired to avoid this unnecessary step for every library.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.