bazelbuild / bazelbuild/rules_android

APK splits should result in smaller intermediate library.ap_ outputs

Open
#16 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
203
Forks
95
PR merge metrics
No merged PRs in 30d

Description

AndroidResourceLink actions don't seem to be affected by APK splits.

if I have

android_binary(
name = "foo",
densities = ["hdpi"],
resource_configuration_filters = ["en"],
deps = [:library_with_resources])

android_library(
name = "library_with_resources"
resource_file = [...])

I'd expect the `AndroidResourceLink` action to honor the filters applied in the binary and produce more minimal outputs but with or without those restrictions the library.ap_ outputs are the same.

Is this by design for some reason I'm missing or is this a good optimization case?

Background: A large amount of our downloads come from large intermediate outputs from AndroidResourceLink.

I suspect https://github.com/bazelbuild/rules_android/issues/10 would help with this too.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.