bazelbuild / bazelbuild/reclient

Mac build fails for --config=goma

Open
#8 2 comments 0 reactions 1 assignee Claimed by @gkousik View on GitHub
Dominant language
Go
Stars
114
Forks
25
PR merge metrics
No merged PRs in 30d

Description

The error message:

```
FAILED: obj/third_party/breakpad/utilities/ConfigFile.o
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MD -MF obj/third_party/breakpad/utilities/ConfigFile.o.d -D_FORTIFY_SOURCE=2 -DCR_CLANG_REVISION=\"llvmorg-18-init-4631-gd50b56d1-1\" -DNDEBUG -DNDEBUG -DENABLE_LZMA -DHAVE_COUNTERZ=1 -I../.. -Igen -I../../third_party/breakpad/breakpad/src -Werror -fstack-protector-all -fPIE -gdwarf-2 -O2 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.0.sdk -mmacosx-version-min=10.7 -arch arm64 -Wno-unused-parameter -Wno-misleading-indentation -Wno-deprecated-non-prototype -Wno-unknown-warning-option -std=c++14 -stdlib=libc++ -fno-exceptions -c ../../third_party/breakpad/breakpad/src/client/mac/crash_generation/ConfigFile.mm -o obj/third_party/breakpad/utilities/ConfigFile.o
../../third_party/breakpad/breakpad/src/client/mac/crash_generation/ConfigFile.mm:108:5: error: 'sprintf' is deprecated: This function is provided for compatibility reasons only. Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Werror,-Wdeprecated-declarations]
108 | sprintf(processUptimeString, "%llu",
| ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.0.sdk/usr/include/stdio.h:188:1: note: 'sprintf' has been explicitly marked deprecated here
188 | __deprecated_msg("This function is provided for compatibility reasons only. Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead.")
| ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.0.sdk/usr/include/sys/cdefs.h:215:48: note: expanded from macro '__deprecated_msg'
215 | #define __deprecated_msg(_msg) __attribute__((__deprecated__(_msg)))
| ^
../../third_party/breakpad/breakpad/src/client/mac/crash_generation/ConfigFile.mm:114:3: error: 'sprintf' is deprecated: This function is provided for compatibility reasons only. Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Werror,-Wdeprecated-declarations]
114 | sprintf(processCrashtimeString, "%zd", tv.tv_sec);
| ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.0.sdk/usr/include/stdio.h:188:1: note: 'sprintf' has been explicitly marked deprecated here
188 | __deprecated_msg("This function is provided for compatibility reasons only. Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead.")
| ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.0.sdk/usr/include/sys/cdefs.h:215:48: note: expanded from macro '__deprecated_msg'
215 | #define __deprecated_msg(_msg) __attribute__((__deprecated__(_msg)))
| ^
2 errors generated.
[656/1257] ACTION //third_party/chartjs:gen_chartjs(//build/toolchain/mac:clang_arm64)
[657/1257] CXX obj/third_party/breakpad/breakpad/crash_generation_client.o
[658/1257] CXX obj/third_party/breakpad/utilities/minidump_generator.o
[659/1257] CXX obj/third_party/chromium_base/cpu/cpu.o
[660/1257] CXX obj/third_party/breakpad/breakpad/exception_handler.o
[661/1257] CXX obj/third_party/breakpad/utilities/string_utilities.o
[662/1257] CXX obj/third_party/breakpad/utilities/string_conversion.o
[663/1257] CXX obj/third_party/breakpad/utilities/dynamic_images.o
[664/1257] OBJCXX obj/third_party/breakpad/crash_inspector/Inspector.o
[665/1257] OBJCXX obj/third_party/breakpad/breakpad/Breakpad.o
[666/1257] CXX obj/third_party/chromium_base/mac_version/mac_version.o
[667/1257] OBJCXX obj/third_party/breakpad/crash_inspector/InspectorMain.o
[668/1257] CC obj/third_party/boringssl/boringssl/bcm.o
ninja: build stopped: subcommand failed.
_____ END BUILD LOGS _____
rules_foreign_cc: Build wrapper script location: bazel-out/darwin_arm64-opt/bin/goma/goma_input_processor_foreign_cc/wrapper_build_script.sh
rules_foreign_cc: Build script location: bazel-out/darwin_arm64-opt/bin/goma/goma_input_processor_foreign_cc/build_script.sh
rules_foreign_cc: Build log location: bazel-out/darwin_arm64-opt/bin/goma/goma_input_processor_foreign_cc/Ninja.log

INFO: Elapsed time: 39.432s, Critical Path: 17.93s
INFO: 265 processes: 3 internal, 262 darwin-sandbox.
FAILED: Build did NOT complete successfully
```

Also, I could not find out how to disable `-Werror` for this build -- I thought that adding `treat_warnings_as_errors=false` [here](https://github.com/bazelbuild/reclient/blob/c0d2c2b03b3cc7b2eeb96760ddfabb862b328eaa/WORKSPACE#L426) or [here](https://github.com/bazelbuild/reclient/blob/c0d2c2b03b3cc7b2eeb96760ddfabb862b328eaa/goma/BUILD.bazel#L31) will do it, but it didn't.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.