bazelbuild / bazelbuild/proposals

designs/2022-06-07-bazel-credential-helpers.md says request has "url", but bazel uses "uri"

Open
#327 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
136
Forks
74
PR merge metrics
No merged PRs in 30d

Description

https://github.com/bazelbuild/proposals/blob/main/designs/2022-06-07-bazel-credential-helpers.md

> get: Retrieves credentials. The payload provided as standard input to the credential helper will be a json object with a single key url containing the url (including the protocol) to get credentials for ({"url": "..."}).

but
https://github.com/bazelbuild/bazel/blob/c00e8e623b717ecb734feeeb8f268af718b95683/src/main/java/com/google/devtools/build/lib/authandtls/credentialhelper/GetCredentialsRequest.java#L66
> writer.name("uri").value(value.getUri().toString());

Contributor guide

Open the contributing guide

Research direction

Read designs/2022-06-07-bazel-credential-helpers.md and compare its credential request field with the linked GetCredentialsRequest.java implementation in Bazel. Resolve the terminology mismatch so the design document accurately describes the implemented request format, then verify the relevant quoted text is consistent.

Written by the indexing model from the issue text.

Assessment

Domain
documentation
Issue type
Documentation
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.