bazelbuild / bazelbuild/examples

Starlark impl function naming convention not clear

Open
#174 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Starlark
Stars
957
Forks
578
Avg merge
3d 22h
Merged PRs (30d)
1

Description

It seems not consistent in a lot of places where `_impl` or `_impl` should be used as convention for the implementation function name. According to doc [here](https://docs.bazel.build/versions/master/skylark/rules.html#implementation-function), it should be `_impl`, but the [example](https://github.com/bazelbuild/examples/blob/master/rules/attributes/printer.bzl) given in the same section uses `_impl`. And the whole [doc](https://docs.bazel.build/versions/master/skylark/rules.html) uses a mix of the two. It caused confusion here https://github.com/bazelbuild/rules_docker/pull/724#discussion_r264527597.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.