bazelbuild / bazelbuild/continuous-integration

Pipeline succeeds if setup step fails

Open
#941 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
302
Forks
194
Avg merge
1d 19h
Merged PRs (30d)
41

Description

If the first step of a pipeline fails (e.g. because the container couldn't be started), the whole pipeline is marked as successful when it shouldn't be. See https://buildkite.com/bazel/bazel-bazel-github-presubmit/builds/5453 as an example of that happening.

Contributor guide

Open the contributing guide

Research direction

Start by reviewing the linked Buildkite build 5453 and trace how pipeline setup-step failures are reported. The fix is complete when a failed initial setup step causes the entire pipeline to be marked unsuccessful, including container-start failures.

Written by the indexing model from the issue text.

Assessment

Domain
ci-cd
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.