bazelbuild / bazelbuild/continuous-integration
Allow buildifier config to exclude paths
- Dominant language
- Python
- Stars
- 302
- Forks
- 194
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 41
Description
In rules_nodejs we vendor some code into third_party (like some bits from skylib)
Thus if I try to enable buildifier on bazel CI it says I have to make changes to that code
https://buildkite.com/bazel/rules-nodejs-nodejs/builds/9363#e2d87cbb-8310-4f80-a63c-30d849cd6d0c
which is not great since then we have diverged from the upstream where we cloned it.
I'd like to say
```yaml
buildifier:
exclude: ^third_party/.*
```
(note, this will further exacerbate the problem of configuring buildifier the same for local dev and for CI. https://github.com/bazelbuild/buildtools/issues/479 is the right fix for that)
Contributor guide
Research direction
No file or test is named; start by locating where the continuous-integration repository defines Buildifier configuration for Bazel CI. Trace how the YAML configuration is read and how paths are checked, then verify that an exclude pattern such as ^third_party/.* prevents vendored files from being reported while other paths remain checked.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- yaml
- Domain
- build-system, ci-cd, tooling
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100