bazelbuild / bazelbuild/bazel

Allow transition on incompatible and experimental native flags

Open
#20,297 3 comments 2 reactions 0 assignees View on GitHub
P2 team-Configurability type: feature request
Dominant language
Java
Stars
25.8k
Forks
4.6k
Avg merge
2d 16h
Merged PRs (30d)
72

Description

### Description of the feature request:

Currently, `--incompatible_*` and `--experimental_*` flags are disallowed in transitions without any justification why. I am currently working on rules_proto's incompatible proto toolchain feature, therefore need to write some tests that needs to transition in order to test the logic.

Currently transitioning on these flags end up in an error, and the reason isn't clear.

```
Error in analysis_test_transition: Invalid transition output '//command_line_option:incompatible_enable_proto_toolchain_resolution'. Cannot transition on --experimental_* or --incompatible_* options
```

It was disabled with this commit; https://github.com/bazelbuild/bazel/commit/ff93b19e496513dd78be4b6bcee0f0105cc17d2b

### Which category does this issue belong to?

_No response_

### What underlying problem are you trying to solve with this feature?

Writing unit tests that test experimental and incompatible flags.

### Which operating system are you running Bazel on?

_No response_

### What is the output of `bazel info release`?

_No response_

### If `bazel info release` returns `development version` or `(@non-git)`, tell us how you built Bazel.

_No response_

### What's the output of `git remote get-url origin; git rev-parse master; git rev-parse HEAD` ?

_No response_

### Have you found anything relevant by searching the web?

_No response_

### Any other information, logs, or outputs that you want to share?

_No response_

Contributor guide

Open the contributing guide

Research direction

Start by reviewing commit ff93b19e496513dd78be4b6bcee0f0105cc17d2b and tracing the transition validation that produces the shown error. Done means transitions on experimental and incompatible flags support the requested testing use case without producing that error, with coverage for the behavior.

Written by the indexing model from the issue text.

Assessment

Domain
build-system
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.