bazelbuild / bazelbuild/bazel

Allow private rule attributes ("_something") to be set from wrapper macros declared with the rule.

Open
#18,563 5 comments 0 reactions 2 assignees Assigned to @brandjon View on GitHub
P2 team-Rules-API type: feature request
Dominant language
Java
Stars
25.8k
Forks
4.6k
Avg merge
2d 20h
Merged PRs (30d)
72

Description

It's a common idiom to use a wrapper macro (call it "foo") around a rule (call it "_foo") to do things like compute defaults. Sometimes these defaults are for values which we want to compute at load time (e.g. glob() results). We can pass this from the wrapper to the implementation with an attribute named "private_something", but that is not idiomatic. We could enhance readability by allowing `_x` attribute names for things passed solely from the wrapper to the implementation.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.