bazelbuild / bazelbuild/bazel

Either support ctx.expand_make_variables or provide a replacement

Open
#18,266 0 comments 4 reactions 0 assignees View on GitHub
team-Rules-API type: process untriaged
Dominant language
Java
Stars
25.8k
Forks
4.6k
Avg merge
2d 20h
Merged PRs (30d)
72

Description

### Description of the bug:

ctx.expand_make_variables has been deprecated for a long time, but the suggested replacement is not sufficient as described in [#5859](https://github.com/bazelbuild/bazel/issues/5859).

Our own team keeps using expand_make_variables ([recently](https://github.com/tensorflow/tensorflow/commit/da439b7d05584f93e745511d66f6d74a58b54b34)) , so we get ever further from deprecation.

We should either support it or prioritize an useful alternative, because the longer we wait, the more it can never be replaced.

Contributor guide

Open the contributing guide

Research direction

Start by reading the ctx.expand_make_variables usage described here and the replacement discussion in issue #5859. Review the linked TensorFlow commit for a concrete consumer example. Done means either the deprecated API is supported or a replacement is defined that covers the documented missing behavior.

Written by the indexing model from the issue text.

Assessment

Domain
build-system
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.