bazelbuild / bazelbuild/bazel

Support label list flags and settings

Open
#17,828 6 comments 1 reaction 0 assignees View on GitHub
P2 team-Configurability type: feature request
Dominant language
Java
Stars
25.8k
Forks
4.6k
Avg merge
2d 18h
Merged PRs (30d)
75

Description

We should add support for comma-separated label list flags (and settings) in [`LabelBuildSettings`](https://cs.opensource.google/bazel/bazel/+/master:src/main/java/com/google/devtools/build/lib/rules/LabelBuildSettings.java), similar to how we have `string_list_flag`.

At this point we shouldn't support `allow_multiple`, see the conversation in comments at https://github.com/bazelbuild/bazel/issues/17477#issuecomment-1474028403

Contributor guide

Open the contributing guide

Research direction

Start with src/main/java/com/google/devtools/build/lib/rules/LabelBuildSettings.java and compare its handling with the existing string_list_flag support. Trace how flags and settings are represented and parsed, then check the linked discussion for the intended limitation. Done means comma-separated label list flags and settings are supported without allow_multiple.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
build-system
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
65/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.