bazelbuild / bazelbuild/bazel

--patch-module javac flag not working when javac strategy is sandboxed

Open
#15,513 4 comments 0 reactions 1 assignee Assigned to @cushon View on GitHub
P2 team-Local-Exec type: bug
Dominant language
Java
Stars
25.8k
Forks
4.6k
Avg merge
2d 20h
Merged PRs (30d)
72

Description

### Description of the bug:

When trying to patch a file into `jdk.unsupported`, using the `--patch-module` javac options succeeds when run with flag `--strategy=Javac=local` but fails when run with flag `--strategy=Javac=sandboxed`.

### What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

Created minimal reproduction: https://github.com/ckilian867/bazel-sandbox-patch-module

### Which operating system are you running Bazel on?

```
PRETTY_NAME="Debian GNU/Linux 10 (buster)"
NAME="Debian GNU/Linux"
VERSION_ID="10"
VERSION="10 (buster)"
VERSION_CODENAME=buster
ID=debian
HOME_URL="https://www.debian.org/"
SUPPORT_URL="https://www.debian.org/support" BUG_REPORT_URL="https://bugs.debian.org/"
```

### What is the output of `bazel info release`?

```
$ bazel info release INFO: Invocation ID: 24daef35-76ab-4f86-a488-83cc55328f87 release 5.1.0
```

### If `bazel info release` returns `development version` or `(@non-git)`, tell us how you built Bazel.

_No response_

### What's the output of `git remote get-url origin; git rev-parse master; git rev-parse HEAD` ?

```
$ git remote get-url origin; git rev-parse master; git rev-parse HEAD
https://github.com/ckilian867/bazel-sandbox-patch-module.git
1fb9443f0c9910f8e21f5cdd504727a972d705f8
1fb9443f0c9910f8e21f5cdd504727a972d705f8
```

### Have you found anything relevant by searching the web?

Nothing related to Bazel's use of `--patch-module`

### Any other information, logs, or outputs that you want to share?

Error output in README of https://github.com/ckilian867/bazel-sandbox-patch-module

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.