bazelbuild / bazelbuild/bazel-toolchains

rbe_configs_gen produces wrongly formatted Starlark code (flagged by buildifier)

Open
#960 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
202
Forks
100
PR merge metrics
No merged PRs in 30d

Description

I generate RBE config using this command:

```
$ ./rbe_configs_gen \
--bazel_version=4.1.0 \
--toolchain_container=l.gcr.io/google/rbe-ubuntu18-04:latest \
--output_src_root=/home/davido/projects/gerrit \
--output_config_path=tools/rbe \
--exec_os=linux \
--target_os=linux
```

and running the latest `buildifier` utility on generated code produces this diff: [1].

Used buildifier version:

```
$ buildifier -version
buildifier version: 4.0.0
buildifier scm revision: 840218fa3afc7e7145c1eeb3bfeb612c497e67f7
```

[1] http://paste.openstack.org/show/805685

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.