bazelbuild / bazelbuild/bazel-skylib

run_binary doesn't use target's RunEnvironmentInfo

Open
#589 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Starlark
Stars
444
Forks
202
PR merge metrics
No merged PRs in 30d

Description

If say `sh_binary` target has `env=` set, then running target directly uses env, but under run_binary `env=` values are getting lost.

Looks related to https://github.com/bazelbuild/bazel-skylib/issues/409 but `run_binary` isn't covered there

Contributor guide

Open the contributing guide

Research direction

Inspect the run_binary rule and compare its handling of a sh_binary target's RunEnvironmentInfo with direct execution. Reproduce the case using a target with env= set, then verify that run_binary preserves those environment values; the related issue 409 provides additional context.

Written by the indexing model from the issue text.

Assessment

Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.