bazelbuild / bazelbuild/bazel-skylib
Typo in selects.bzl
Open
- Dominant language
- Starlark
- Stars
- 444
- Forks
- 202
- PR merge metrics
- No merged PRs in 30d
Description
https://github.com/bazelbuild/bazel-skylib/blob/5bfcb1a684550626ce138fe0fe8f5f702b3764c3/lib/selects.bzl#L141
```
for setting in settings:
if settings != "//conditions:default":
new_settings.append(setting)
return new_settings
```
This should've been `if setting != "//conditions:default":`
Contributor guide
Research direction
Open lib/selects.bzl at line 141 and compare the loop variable with the condition used in the issue. Verify that the default condition is tested for each setting, then run the relevant Bazel tests or checks for selects.bzl and confirm the typo no longer causes incorrect filtering.
Written by the indexing model from the issue text.
Assessment
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100