bazelbuild / bazelbuild/bazel-skylib

analysistest: Propagate toolchains

Open
#375 1 comment 0 reactions 0 assignees View on GitHub
more data needed type: feature request
Dominant language
Starlark
Stars
444
Forks
202
PR merge metrics
No merged PRs in 30d

Description

The `toolchains` attribute is hard-coded to just the skylib unit test toolchain type. See:

https://github.com/bazelbuild/bazel-skylib/blob/a501641daebdce8601ee6bbc6b5d177c688d3517/lib/unittest.bzl#L286

Should it propagate the toolchains for testing them?

Contributor guide

Open the contributing guide

Research direction

Start at lib/unittest.bzl around line 286, where the analysistest toolchains attribute is hard-coded. Read the surrounding analysistest implementation and relevant tests to determine the expected propagation behavior; done means testing toolchains are propagated rather than limited to the skylib unit test toolchain type.

Written by the indexing model from the issue text.

Assessment

Domain
build-system
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.