bazelbuild / bazelbuild/bazel-skylib

Potential conflict between Google3 and external naming conventions for `bzl_library`

Open
#284 4 comments 0 reactions 1 assignee Claimed by @achew22 View on GitHub
P3 type: bug
Dominant language
Starlark
Stars
444
Forks
202
PR merge metrics
No merged PRs in 30d

Description

Hey @aiuto, @jin, @c-parsons, CC @jayconrod,

I have been going through getting `bzl_library` targets added to a bunch of repos and I had a realization about it. I think there is someone @ google who is doing the same thing from inside G3. I was trying to figure out why https://github.com/bazelbuild/rules_cc/commit/991eb349bf648b89f7d039a2602d337c85479534 creates a bunch of targets that have `//visibility:private`. That's a super silly thing to do, but I think I figured out why.

I think that this is stage 1 of a multi part LSC to add `bzl_libraries` and I'm a little worried that the gazelle generator in this repo is incompatible with it. The LSC seems to be going with names that end in `_bzl` while I decided to strip the suffix. Is there any way I could have someone look at http://cl/340301767 (referenced in that commit) and tell me if bazel-skylib's automation is incompatible with the automation I suspect is being written.

If it is, what do you think the correct course of action should be here? My inclination is to update the Gazelle generator to match their `_bzl` suffix and manually fix all the people who've adopted so far and apologize.

What do you think about that? My email is attached to a bunch of commits in this repo if you would like to have this conversation in a less open medium.

Thanks so much!

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.