bazelbuild / bazelbuild/bazel-skylib

Build kite says failing because of lint errors

Open
#247 8 comments 0 reactions 0 assignees View on GitHub
Dominant language
Starlark
Stars
444
Forks
202
PR merge metrics
No merged PRs in 30d

Description

[Example failures](https://buildkite.com/bazel/bazel-skylib/builds/993)

These appear to be mostly from analysis-time test suites, which are implemented as macros but do not (and should not) have a `name` parameter. We should have a way to disable this lint for these files, but it's also a more general problem for anyone using buildifier with this analysis testing paradigm.

Contributor guide

Open the contributing guide

Research direction

Start with the linked Buildkite failures and inspect the analysis-time test suites described in the issue, along with how buildifier applies the lint. Done means there is a way to disable this lint for files using analysis-testing macros without requiring a name parameter.

Written by the indexing model from the issue text.

Assessment

Domain
build-system, tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.