bazelbuild / bazelbuild/bazel-skylib

Flag --incompatible_disallow_empty_glob will break Bazel skylib in Bazel 1.2.1

Open
#219 2 comments 0 reactions 0 assignees View on GitHub
P4 type: process
Dominant language
Starlark
Stars
444
Forks
202
PR merge metrics
No merged PRs in 30d

Description

Incompatible flag --incompatible_disallow_empty_glob will break Bazel skylib once Bazel 1.2.1 is released.

Please see the following CI builds for more information:

* [:windows: (OpenJDK 8)](:windows: (OpenJDK 8))
* [:ubuntu: 16.04 (OpenJDK 8)](:ubuntu: 16.04 (OpenJDK 8))
* [:ubuntu: 18.04 (OpenJDK 11)](:ubuntu: 18.04 (OpenJDK 11))
* [:darwin: (OpenJDK 8)](:darwin: (OpenJDK 8))

Questions? Please file an issue in https://github.com/bazelbuild/continuous-integration

**Important**: Please do NOT modify the issue title since that might break our tools.

Contributor guide

Open the contributing guide

Research direction

Start with the four linked Bazel CI failures and compare the failing skylib behavior with the affected glob usage. Identify the compatibility changes required for --incompatible_disallow_empty_glob, then verify that the referenced Windows, Ubuntu, and Darwin builds pass with the flag enabled.

Written by the indexing model from the issue text.

Assessment

Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.