bazel-xcode / bazel-xcode/PodToBUILD

Error unzip pod with folder with a special character

Open
#177 0 comments 0 reactions 0 assignees Claimed by @rquesada View on GitHub
Dominant language
Swift
Stars
330
Forks
68
PR merge metrics
No merged PRs in 30d

Description

If I try to add a pod that a have a special character in its name (emoji o Chinese character) the command `make pods` or `make pods_debug` fail.
The issue is caused by unzip command.

Example:
https://github.com/danielgindi/Charts/
In the path:
Test/ChartsTests/__Snapshots__Silicon__

### **What did you do?**
I add the following pod to Pods.WORSPACE
`new_pod_repository(
name = "Charts",
url = "https://github.com/danielgindi/Charts/archive/refs/tags/v4.0.1.zip",
)`

### **What did you expect to happen?**
The Library added correctly.

### **What happened instead?**
I got the following error:
checkdir error: cannot create OUT/Charts-4.0.1/Tests/ChartsTests/Snapshots??+Silicon__
Illegal byte sequence
unable to process Charts-4.0.1/Tests/ChartsTests/Snapshots??+Silicon__/.
checkdir error: cannot create OUT/Charts-4.0.1/Tests/ChartsTests/Snapshots??+Silicon__
Illegal byte sequence
unable to process Charts-4.0.1/Tests/ChartsTests/Snapshots??+Silicon__/BarChartTests/.
checkdir error: cannot create OUT/Charts-4.0.1/Tests/ChartsTests/Snapshots??+Silicon__
Illegal byte sequence
unable to process Charts-4.0.1/Tests/ChartsTests/Snapshots??+Silicon__/BarChartTests/testDefaultBarDataSetLabels-iOS_390-0_844-0.1.png.
....

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.