bazel-contrib / bazel-contrib/toolchains_llvm

Incorrect documentation about `sysroot` extension.

Open
#621 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Starlark
Stars
371
Forks
283
Avg merge
1d 55m
Merged PRs (30d)
25

Description

https://github.com/bazel-contrib/toolchains_llvm/blob/43e5dc41535c0f8d4f3573c7373caf10e883e4bb/toolchain/extensions/llvm.bzl#L121C17-L121C118

As best I can tell, this comment is incorrectly documenting the current behavior in which an empty set of targets means the sysroot definition is entirely ignored.

Contributor guide

Open the contributing guide

Research direction

Review toolchain/extensions/llvm.bzl at the linked comment around line 121 and compare its wording with the current sysroot behavior when the target set is empty. Update the documentation to describe that behavior accurately, then verify the surrounding extension documentation remains consistent.

Written by the indexing model from the issue text.

Assessment

Domain
build-system, documentation
Issue type
Documentation
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.