bazel-contrib / bazel-contrib/toolchains_llvm

made cxx_builtin_include_directories also support an empty key

Open
#349 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Starlark
Stars
371
Forks
283
Avg merge
1d 55m
Merged PRs (30d)
25

Description

as title, hope most attr can support empty key like toolchain_roots attr

Contributor guide

Open the contributing guide

Research direction

Start by locating the definitions and handling for cxx_builtin_include_directories and toolchain_roots. Compare how toolchain_roots accepts an empty key, then determine the expected equivalent behavior for cxx_builtin_include_directories. Done means the empty-key case is supported consistently and covered by the relevant tests, though no test file is named in the issue.

Written by the indexing model from the issue text.

Assessment

Domain
build-system
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.