bazel-contrib / bazel-contrib/target-determinator

--enforce-clean accepts a tri-state value but only has boolean behaviour

Open
#87 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
182
Forks
33
PR merge metrics
No merged PRs in 30d

Description

As far as I can tell, there is no code which differentiates between `AllowIgnored` and `AllowDirty`... @sitaktif do you remember any history here? AFAICT there has never been any code which differentiates between these, or any tests which set `--enforce-clean=allow-dirty` (or indeed which set `--enforce-clean=allow-ignored`)?

https://github.com/bazel-contrib/target-determinator/pull/86 is going to simplify this behaviour to be more boolean (but doesn't remove the three variants) - I _think_ this is ok (and that we should just remove the extra unused variant), but figured I should file an issue to discuss...

Contributor guide

Open the contributing guide

Research direction

Review PR #86 and trace the implementation of the --enforce-clean flag, including how its three values are parsed and used. Search the repository for tests or code covering allow-dirty and allow-ignored, then compare the findings with the issue's history. Done means the supported behavior and remaining variants are consistent and covered by appropriate tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
build-system, cli
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.