bazel-contrib / bazel-contrib/setup-bazel

Handle GitHub Action Names with extra characters

Open
#72 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
83
Forks
32
PR merge metrics
No merged PRs in 30d

Description

E.g. [this](https://github.com/enola-dev/enola/actions/runs/13642687157/job/38135724347) failed due to:

```
Run bazel-contrib/setup-bazel@0.14.0
Configure Bazel
Setup Bazelisk
Restore cache for bazelisk
Restore cache for disk-Build, Test & Deploy (CI)

/home/runner/work/_actions/bazel-contrib/setup-bazel/0.[14](https://github.com/enola-dev/enola/actions/runs/13642687157/job/38135724347#step:9:15).0/dist/node_modules/@actions/cache/lib/cache.js:71
throw new ValidationError(`Key Validation Error: ${key} cannot contain commas.`);
^
ValidationError: Key Validation Error: setup-bazel-1-linux-disk-Build, Test & Deploy (CI)-5478129354fce37d2c7d5ab200e2f93e03c4aee6fabc88b08289fb8bf292d70d cannot contain commas.
at checkKey (/home/runner/work/_actions/bazel-contrib/setup-bazel/0.14.0/dist/node_modules/@actions/cache/lib/cache.js:71:1)
at /home/runner/work/_actions/bazel-contrib/setup-bazel/0.14.0/dist/node_modules/@actions/cache/lib/cache.js:203:1
at Generator.next ()
at /home/runner/work/_actions/bazel-contrib/setup-bazel/0.14.0/dist/node_modules/@actions/cache/lib/cache.js:31:1
at new Promise ()
at __webpack_modules__.5116.__awaiter (/home/runner/work/_actions/bazel-contrib/setup-bazel/0.14.0/dist/node_modules/@actions/cache/lib/cache.js:27:1)
at restoreCacheV2 (/home/runner/work/_actions/bazel-contrib/setup-bazel/0.14.0/dist/node_modules/@actions/cache/lib/cache.js:192:1)
at Object. (/home/runner/work/_actions/bazel-contrib/setup-bazel/0.14.0/dist/node_modules/@actions/cache/lib/cache.js:100:1)
at Generator.next ()
at /home/runner/work/_actions/bazel-contrib/setup-bazel/0.14.0/dist/node_modules/@actions/cache/lib/cache.js:31:1
```

I've realized that it's [because of this change](https://github.com/enola-dev/enola/commit/fd150c531c6f351ae89459e238e8d5eb84565b14).

It's easily fixed (worked around), but in an ideal world, perhaps it would be more robust and handle GitHub Action names with extra characters?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.